I think one can add openssl via vcpkg: https://github.com/sfackler/rust-openssl/blob/master/.github/workflows/ci.yml#L94

Ideally, yes, one would add windows CI too so that it can be tested on windows as well, given we have windows platform specific tests now.

I think one can add openssl via vcpkg: https://github.com/sfackler/rust-openssl/blob/master/.github/workflows/ci.yml#L94

This did indeed solve this particular issue, but I've been getting some follow up issues for other packages. I've resolved one. but currently I'm stuck on building botan. Trying to resolve these other issues is unfortunately taking more time than I currently have to offer, so I'm not quite sure when I will be able to finish up this PR.

@frjonsen it's ok, is there a way to mark a github CI job as allow failure? Or alternatively, one could comment it all out.

@frjonsen it's ok, is there a way to mark a github CI job as allow failure? Or alternatively, one could comment it all out.

Could probably do that. I see though that you've been working on resolving this, so thanks for that. I was looking into this during work time, so unfortunately had to prioritize other things, since using the pem lib directly does work as a workaround.

I see though that you've been working on resolving this, so thanks for that.

I've thought that your PR is useful and it's not really your fault that there is no CI for windows right now, so I thought I would help you. PR #103 I left open for a long time hoping for smaller fixes to it, but they didn't happen. Later on it turned out that one of the functions I wrote to support that PR had an issue.

botan's maintainer has been very helpful in resolving the build issues on windows, I think now we'll have to wait until a release of botan includes randombit/botan#3504

Update: there has been no release of botan yet. There is also a PR randombit/botan-rs#84 to add windows CI to botan-rs, which seems to be green for them.

Hi @est31 just wanted to give an update here - newly released botan 0.10.3 does include the support for setting the source file link method. But Windows CI is still stalled, it is "green" but actually a no-op. I need to write a new script for CI orchestration.

Hmm I wonder if it's possible to have the botan dev dependency and tests only for non-windows platforms. @frjonsen could you put botan into [target.'cfg(not(windows))'.dependencies] in Cargo.toml, and add cfg's to the test file?

Hmm I pushed it manually... now it complains about openssl not being found :/ Not sure why that is the case given that we install it just before via vcpkg.

I have successfully merged this PR by disabling botan on the windows CI. Sorry for the delay @frjonsen. I have opened #125 for enabling botan on the windows CI once it's ready.

Thanks for finishing the PR. It looks like you had a very productive day yesterday!

Yes I did some trial and error with the CI to make it green. Sorry for the notification noise :).