Skip to content

fix: make ignore's .git_exclude() mirror .git_ignore()#494

Merged
aawsome merged 2 commits intorustic-rs:mainfrom
hacker:fix/git-exclude-ignore
Mar 29, 2026
Merged

fix: make ignore's .git_exclude() mirror .git_ignore()#494
aawsome merged 2 commits intorustic-rs:mainfrom
hacker:fix/git-exclude-ignore

Conversation

@hacker
Copy link
Copy Markdown
Contributor

@hacker hacker commented Mar 28, 2026

apparently, ignore crate has its git_exclude on by default and the change is essential to make it possible to backup data listed in .git/info/exclude files.

And it makes the behaviour close to "what would git do".

And it should close rustic-rs/rustic#1261

hacker and others added 2 commits March 28, 2026 14:43
apparently, `ignore` crate has its `git_exclude` on by default
and the change is essential to make it possible to backup data
listed in `.git/info/exclude` files.

And it makes the behaviour close to "what would git do".
Copy link
Copy Markdown
Member

@aawsome aawsome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @hacker for the fix!

@aawsome aawsome added this pull request to the merge queue Mar 29, 2026
Merged via the queue into rustic-rs:main with commit 2c840cf Mar 29, 2026
22 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Apr 5, 2026
## 🤖 New release

* `rustic_core`: 0.10.1 -> 0.11.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.11.0](rustic_core-v0.10.1...rustic_core-v0.11.0)
- 2026-04-05

### Added

- Optimize hardlink creation in restore
([#495](#495))
- add exclude-if-xattr option
([#491](#491))

### Fixed

- make `ignore`'s `.git_exclude()` mirror `.git_ignore()`
([#494](#494))

### Other

- update dependencies
([#496](#496))
- preserve hardlinks on restore
([#492](#492))
- use general tree modifier in `repair snapshots`
([#463](#463))
- [**breaking**] Optimize file streaming
([#489](#489))
- [**breaking**] use Cow to avoid OsString allocations
([#487](#487))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Should not look for .git or .git/info/exclude if git-ignore = false

2 participants