Skip to content

feat: Add a "minutely" timeline#374

Merged
simonsan merged 4 commits intorustic-rs:mainfrom
jullanggit:keep_minutely
Nov 30, 2024
Merged

feat: Add a "minutely" timeline#374
simonsan merged 4 commits intorustic-rs:mainfrom
jullanggit:keep_minutely

Conversation

@jullanggit
Copy link
Copy Markdown
Contributor

@jullanggit jullanggit commented Nov 28, 2024

Disclaimer

I am not very experienced with contributing to projects like rustic, so please correct me if I make any mistakes or could improve something about this PR!
In this case, I am particularly unsure about the commit message and how to add tests, so any tips there would be appreciated 😄

Motivation

As creating a rustic snapshot can be really fast if not much has changed (less than 10s), I have started to backup-up my files every ten minutes, but noticed that rustic doesn't yet have any keep-options for sub-hourly snapshots, so I decided to add them!

@jullanggit jullanggit changed the title Add a "minutely" timeline feat: Add a "minutely" timeline Nov 28, 2024
aawsome
aawsome reviewed Nov 29, 2024
View reviewed changes
@simonsan
Copy link
Copy Markdown
Contributor

simonsan commented Nov 29, 2024 •
edited
Loading

Please also add an explanation to ./config/full.toml and the ./config/Readme.md 📓 of rustic itself, when this is merged. As we need to implement the additions then also in rustic.

@jullanggit jullanggit mentioned this pull request Nov 29, 2024
Merged
@jullanggit
Copy link
Copy Markdown
Contributor Author

jullanggit commented Nov 29, 2024

The clippy CI shows some warnings/errors. Should I try to fix them? (most of them are not related to this PR)

@aawsome
Copy link
Copy Markdown
Member

aawsome commented Nov 29, 2024

@jullanggit Ah, I think these are due to a new Rust version. We should fix those in a separate PR before we merge this one...

@aawsome
Copy link
Copy Markdown
Member

aawsome commented Nov 29, 2024

It would be great if you could extend/adapt the unittests in forget.rs to cover the new option, @jullanggit Besides this, this PR looks good to me, just needs to wait until we fix the clippy lints in master. Thanks a lot for the contribution!

@simonsan
Copy link
Copy Markdown
Contributor

simonsan commented Nov 29, 2024

The only thing missing now for clippy is the #[allow(clippy::too_many_lines)] annotation on matches().

@simonsan simonsan added this pull request to the merge queue Nov 30, 2024
@simonsan
Copy link
Copy Markdown
Contributor

simonsan commented Nov 30, 2024

Thank you for the contribution! 🚀 :)

Merged via the queue into rustic-rs:main with commit 534efbd Nov 30, 2024
@rustic-release-plz rustic-release-plz bot mentioned this pull request Nov 29, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 30, 2024
@rustic-release-plz
chore(rustic_core): release v0.7.2 (#375)
3d40e8d 
## 🤖 New release
* `rustic_core`: 0.7.1 -> 0.7.2 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_core`
<blockquote>

##
[0.7.2](rustic_core-v0.7.1...rustic_core-v0.7.2)
- 2024-11-30

### Added

- Add a "minutely" timeline
([#374](#374))

### Fixed

- clippy lints
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
simonsan added a commit to rustic-rs/rustic that referenced this pull request Nov 30, 2024
@jullanggit @simonsan
docs: Add documentation for minutely keep option (#1371)
11b772d 
Adds documentation for the minutely timeline
(rustic-rs/rustic_core#374) in
`./config/full.toml` and `./config/README.md`

Co-authored-by: simonsan <14062932+simonsan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aawsome aawsome aawsome left review comments

@simonsan simonsan simonsan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jullanggit @simonsan @aawsome