Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
simonsan
approved these changes
Nov 24, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 24, 2024
## 🤖 New release * `rustic_backend`: 0.5.0 -> 0.5.1 (✓ API compatible changes) * `rustic_core`: 0.6.1 -> 0.7.0 (⚠️ API breaking changes) * `rustic_testing`: 0.3.0 -> 0.3.1 (✓ API compatible changes) ###⚠️ `rustic_core` breaking changes ``` --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/inherent_method_missing.ron Failed in: Vfs::into_webdav_fs, previously in file /tmp/.tmpgG4RJE/rustic_core/src/vfs.rs:470 Repository::is_async_compatible, previously in file /tmp/.tmpgG4RJE/rustic_core/src/repository.rs:716 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/struct_missing.ron Failed in: struct rustic_core::vfs::WebDavFS, previously in file /tmp/.tmpgG4RJE/rustic_core/src/vfs/webdavfs.rs:51 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/trait_method_missing.ron Failed in: method is_async_compatible of trait ReadBackend, previously in file /tmp/.tmpgG4RJE/rustic_core/src/backend.rs:189 ``` <details><summary><i><b>Changelog</b></i></summary><p> ## `rustic_backend` <blockquote> ## [0.5.1](rustic_backend-v0.5.0...rustic_backend-v0.5.1) - 2024-11-24 ### Other - Revert "feat(async): add `async_compatible` methods to identify backend compatibility ([#355](#355))" </blockquote> ## `rustic_core` <blockquote> ## [0.7.0](rustic_core-v0.6.1...rustic_core-v0.7.0) - 2024-11-24 ### Other - remove webdav feature ([#366](#366)) - Revert "feat(async): add `async_compatible` methods to identify backend compatibility ([#355](#355))" </blockquote> ## `rustic_testing` <blockquote> ## [0.3.1](rustic_testing-v0.3.0...rustic_testing-v0.3.1) - 2024-11-24 ### Other - Revert "feat(async): add `async_compatible` methods to identify backend compatibility ([#355](#355))" </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer needed as
WebDavFsis implemented now directly in rustic.The implementation anyhow is not correct as blocking methods are called directly in async context.