Skip to content

refactor: remove webdav feature#366

Merged
simonsan merged 2 commits intomainfrom
remove-webdav
Nov 24, 2024
Merged

refactor: remove webdav feature#366
simonsan merged 2 commits intomainfrom
remove-webdav

Conversation

@aawsome
Copy link
Copy Markdown
Member

@aawsome aawsome commented Nov 24, 2024

No longer needed as WebDavFs is implemented now directly in rustic.
The implementation anyhow is not correct as blocking methods are called directly in async context.

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.1%. Comparing base (55e33db) to head (f97075f).
Report is 1 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/vfs.rs 10.9% <ø> (+<0.1%) ⬆️

... and 19 files with indirect coverage changes

---- 🚨 Try these New Features:

@simonsan simonsan added this pull request to the merge queue Nov 24, 2024
@simonsan simonsan removed this pull request from the merge queue due to a manual request Nov 24, 2024
@simonsan simonsan enabled auto-merge November 24, 2024 08:59
@simonsan simonsan added this pull request to the merge queue Nov 24, 2024
Merged via the queue into main with commit 60a7e31 Nov 24, 2024
@simonsan simonsan deleted the remove-webdav branch November 24, 2024 09:45
@rustic-release-plz rustic-release-plz bot mentioned this pull request Nov 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 24, 2024
## 🤖 New release
* `rustic_backend`: 0.5.0 -> 0.5.1 (✓ API compatible changes)
* `rustic_core`: 0.6.1 -> 0.7.0 (⚠️ API breaking changes)
* `rustic_testing`: 0.3.0 -> 0.3.1 (✓ API compatible changes)

### ⚠️ `rustic_core` breaking changes

```
--- failure inherent_method_missing: pub method removed or renamed ---

Description:
A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/inherent_method_missing.ron

Failed in:
  Vfs::into_webdav_fs, previously in file /tmp/.tmpgG4RJE/rustic_core/src/vfs.rs:470
  Repository::is_async_compatible, previously in file /tmp/.tmpgG4RJE/rustic_core/src/repository.rs:716

--- failure struct_missing: pub struct removed or renamed ---

Description:
A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/struct_missing.ron

Failed in:
  struct rustic_core::vfs::WebDavFS, previously in file /tmp/.tmpgG4RJE/rustic_core/src/vfs/webdavfs.rs:51

--- failure trait_method_missing: pub trait method removed or renamed ---

Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.36.0/src/lints/trait_method_missing.ron

Failed in:
  method is_async_compatible of trait ReadBackend, previously in file /tmp/.tmpgG4RJE/rustic_core/src/backend.rs:189
```

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_backend`
<blockquote>

##
[0.5.1](rustic_backend-v0.5.0...rustic_backend-v0.5.1)
- 2024-11-24

### Other

- Revert "feat(async): add `async_compatible` methods to identify
backend compatibility
([#355](#355))"
</blockquote>

## `rustic_core`
<blockquote>

##
[0.7.0](rustic_core-v0.6.1...rustic_core-v0.7.0)
- 2024-11-24

### Other

- remove webdav feature
([#366](#366))
- Revert "feat(async): add `async_compatible` methods to identify
backend compatibility
([#355](#355))"
</blockquote>

## `rustic_testing`
<blockquote>

##
[0.3.1](rustic_testing-v0.3.0...rustic_testing-v0.3.1)
- 2024-11-24

### Other

- Revert "feat(async): add `async_compatible` methods to identify
backend compatibility
([#355](#355))"
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants