Skip to content

feat(commands): Add convenient names for read-data-subset n/m#328

Merged
simonsan merged 2 commits intomainfrom
check-subset-names
Oct 14, 2024
Merged

feat(commands): Add convenient names for read-data-subset n/m#328
simonsan merged 2 commits intomainfrom
check-subset-names

Conversation

@aawsome
Copy link
Copy Markdown
Member

@aawsome aawsome commented Oct 11, 2024

This PR adds convenience names for the -read-data-subset=n/m option which allow for more easy regular check runs which cover the whole repository data over a given period.

E.g. it allows to daily run check --read-data --read-data-subset=daily/month which covers the repository once run at every day of any month. Before, this requirement needed scripting to set n to the number of the current day within the month and m to the total count of days in the current month.

For n, it is now allowed to use

  • hourly
  • daily
  • weekly
  • monthly
  • yearly
    which is replaced by an index corresponding to the date/time the check command is called.

For m, it is now allowed to use

  • day
  • week
  • month
  • year
    which is depending on n replaced by the total count of hours/days/weeks/months within the current entity. Moreover month_hours, month_days, year_hours, year_days which work independent from n.

@aawsome aawsome changed the title feat: Add convenient names for read-data-subset feat(commands): Add convenient names for read-data-subset Oct 11, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.0%. Comparing base (2b32031) to head (53c43bd).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/commands/check.rs 92.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/commands/check.rs 66.2% <92.0%> (+2.6%) ⬆️

... and 17 files with indirect coverage changes

@aawsome aawsome changed the title feat(commands): Add convenient names for read-data-subset feat(commands): Add convenient names for read-data-subset n/m Oct 11, 2024
@aawsome aawsome added the S-waiting-for-review Status: PRs waiting for review label Oct 13, 2024
@simonsan simonsan added this pull request to the merge queue Oct 14, 2024
@simonsan simonsan added C-enhancement Category: New feature or request A-commands Area: Related to commands in `rustic_core` and removed S-waiting-for-review Status: PRs waiting for review labels Oct 14, 2024
Merged via the queue into main with commit 6e989b0 Oct 14, 2024
@simonsan simonsan deleted the check-subset-names branch October 14, 2024 22:16
@rustic-release-plz rustic-release-plz bot mentioned this pull request Oct 14, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
## 🤖 New release
* `rustic_backend`: 0.4.1 -> 0.4.2 (✓ API compatible changes)
* `rustic_core`: 0.5.3 -> 0.5.4 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `rustic_backend`
<blockquote>

##
[0.4.2](rustic_backend-v0.4.1...rustic_backend-v0.4.2)
- 2024-10-24

### Fixed

- fix opendal paths on windows
([#340](#340))
</blockquote>

## `rustic_core`
<blockquote>

##
[0.5.4](rustic_core-v0.5.3...rustic_core-v0.5.4)
- 2024-10-24

### Added

- *(commands)* Add convenient names for read-data-subset n/m
([#328](#328))

### Fixed

- OpenFile::read_at no longer errors on invalid offset or length
([#331](#331))

### Other

- *(deps)* update actions
([#338](#338))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-commands Area: Related to commands in `rustic_core` C-enhancement Category: New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants