feat(async): use is_async_compatible() to determine backend incompatibility and error out#1355
Merged
simonsan merged 6 commits intorustic-rs:mainfrom Nov 21, 2024
Merged
Conversation
Contributor
Author
|
for now clippy fails because we are waiting for rustic_core PR to be merged |
d9ece9b to
6552020
Compare
is_async_compatible() to determine backend incompatibility and error out
simonsan
approved these changes
Nov 21, 2024
Contributor
simonsan
left a comment
There was a problem hiding this comment.
I guess, that this is all we can do about it for now. So, LGTM!
Merged
aawsome
added a commit
that referenced
this pull request
Dec 2, 2024
## 🤖 New release * `rustic-rs`: 0.9.4 -> 0.9.5 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.9.5](v0.9.4...v0.9.5) - 2024-12-02 ### Added - *(commands)* More dump options ([#1339](#1339)) - shut down gracefully with ctrl+c ([#1364](#1364)) - Add --filter-jq option ([#1372](#1372)) - *(async)* use `is_async_compatible()` to determine backend incompatibility and error out ([#1355](#1355)) - *(commands)* Add `mount` command ([#973](#973)) ### Fixed - *(commands)* run backup hooks before checking source dir ([#1374](#1374)) - *(commands)* Use spawn_blocking in webdav when calling rustic_core ([#1365](#1365)) - *(filesystem)* Use channels to communicate within webdav filesystem ([#1361](#1361)) ### Other - Add documentation for `minutely` keep option ([#1371](#1371)) - update snapshots to include minutely configuration options - *(deps)* update rustic_core, bytes, and libc dependencies to latest versions - simplify lifetime annotations in OpenFileReader and TreeIterItem implementations - clean up whitespace and update clippy linting allowances - *(deps)* update dependencies to latest versions - *(deps)* update lockfile to get rid of vulnerable `url` version - *(mount)* rename fields for clarity, add user options for mount ([#1353](#1353)) - *(deps)* update dependencies - *(deps)* don't use rustic_core webdav feature ([#1367](#1367)) - Revert "fix(filesystem): Use channels to communicate within webdav filesystem ([#1361](#1361))" - Revert "feat(async): use `is_async_compatible()` to determine backend incompatibility and error out ([#1355](#1355))" - move `webdavfs` from `rustic_core` to `rustic-rs` ([#1363](#1363)) - *(clippy)* comment out unused lints in lib.rs - *(clippy)* apply fixes automatically - use BTreeMap for env in global options ([#1360](#1360)) - add tiny framework for testing rustic's compat with latest restic ([#1303](#1303)) - use snapshot tests for default config, show-config and completions ([#1359](#1359)) - *(deps)* update dependencies rustic_core, rustic_backend, rustic_testing, and migrate to conflate 0.3 ([#1357](#1357)) - fix typos - *(build)* add platform-dependent settings and remove ci flag for extra features - clarify `--use-profile` command in config by using long form ([#1344](#1344)) - *(deps)* update core and testing crates ([#1340](#1340)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: rustic-release-plz[bot] <182542030+rustic-release-plz[bot]@users.noreply.github.com> Co-authored-by: Alexander Weiss <alex@weissfam.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
gettersto early exit webdav when usingasync_incompatiblebackends.Using the type system or fixing all async compatibility issue is big and structural work.
To avoid runtime crash for our users I suggest using this getter as a temporary fix.
tracking issue: #1181 (see for more details)
Before merging this one:
async_compatiblemethods to identify backend compatibility rustic_core#355.