Default to helm chart version for docker image and not latest #1385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mkrueger92 <7305571+mkrueger92@users.noreply.github.com>
The default version is in the chart definition. Signed-off-by: mkrueger92 <7305571+mkrueger92@users.noreply.github.com>
majinghe
reviewed
Jan 5, 2026
Contributor
|
@mkrueger92 Thx for your contribution. /LGTM /cc @houseme @loverustfs |
houseme
approved these changes
Jan 8, 2026
reatang
pushed a commit
that referenced
this pull request
Jan 11, 2026
Signed-off-by: mkrueger92 <7305571+mkrueger92@users.noreply.github.com> Co-authored-by: houseme <housemecn@gmail.com>
weisd
pushed a commit
to weisd/rustfs
that referenced
this pull request
Jan 12, 2026
…#1385) Signed-off-by: mkrueger92 <7305571+mkrueger92@users.noreply.github.com> Co-authored-by: houseme <housemecn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
Summary of Changes
This PR changes the default image version to the one defined in the helm chart. The version "latest" is a bad choice for a stable production environment.
Checklist
make pre-commitImpact
Additional Notes
Leaving the tag blank does a fallback does a fallback:
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.