Skip to content

Conversation

@0xdx2
Copy link
Contributor

@0xdx2 0xdx2 commented Dec 19, 2025

…imiters

Type of Change

  • New Feature
  • Bug Fix
  • Documentation
  • Performance Improvement
  • Test/CI
  • Refactor
  • Other:

Related Issues

Summary of Changes

Checklist

  • I have read and followed the CONTRIBUTING.md guidelines
  • Passed make pre-commit
  • Added/updated necessary tests
  • Documentation updated (if needed)
  • CI/CD passed (if applicable)

Impact

  • Breaking change (compatibility)
  • Requires doc/config/deployment update
  • Other impact:

Additional Notes


Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.

@0xdx2 0xdx2 changed the title Update argument parsing for volumes and server_domains to support del… fix(config):Update argument parsing for volumes and server_domains to support del… Dec 19, 2025
@damonxue damonxue requested a review from Copilot December 19, 2025 15:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds value_delimiter attributes to the argument parsing configuration for the volumes and server_domains fields, enabling these fields to accept delimited values from environment variables or command-line arguments.

Key changes:

  • Added space delimiter (' ') for the volumes parameter to support space-separated volume paths
  • Added comma delimiter (',') for the server_domains parameter to support comma-separated domain names

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 4 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

houseme and others added 2 commits December 21, 2025 17:01
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: houseme <housemecn@gmail.com>
@houseme houseme merged commit 3e2252e into rustfs:main Dec 21, 2025
14 checks passed
@0xdx2 0xdx2 deleted the fix_server_domains branch December 21, 2025 10:57
weisd pushed a commit that referenced this pull request Dec 22, 2025
… support del… (#1209)

Signed-off-by: houseme <housemecn@gmail.com>
Co-authored-by: houseme <housemecn@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jurim76 pushed a commit to jurim76/rustfs that referenced this pull request Dec 22, 2025
… support del… (rustfs#1209)

Signed-off-by: houseme <housemecn@gmail.com>
Co-authored-by: houseme <housemecn@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants