add image pull secret support #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Already tested on local env, if specify |
houseme
approved these changes
Dec 12, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for pulling container images from private registries in the RustFS Helm chart by implementing image pull secrets configuration and automation.
Key changes:
- Added configurable image pull secret support with automatic secret generation
- Introduced
imageRegistryCredentialssection in values.yaml for registry authentication - Updated deployment and statefulset templates to use image pull secrets
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| helm/rustfs/values.yaml | Added imagePullSecrets configuration and imageRegistryCredentials section for private registry authentication |
| helm/rustfs/templates/_helpers.tpl | Added imagePullSecret helper template to generate dockerconfigjson content |
| helm/rustfs/templates/secret.yaml | Added Kubernetes secret resource for image pull credentials |
| helm/rustfs/templates/deployment.yaml | Integrated imagePullSecrets into pod spec |
| helm/rustfs/templates/statefulset.yaml | Integrated imagePullSecrets into pod spec |
| helm/README.md | Updated documentation with new parameters and corrected typo in "traefik" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
15 tasks
houseme
added a commit
that referenced
this pull request
Dec 13, 2025
…ix-ci-1212 * 'fix/fix-ci-1212' of github.com:rustfs/rustfs: fix: update tool chain make everything happy (#1134) render imagePullSecrets in Deployment/StatefulSet (#1130) Update end-to-end test script path Increase parallelism in CI build and test steps Reorder s3s-e2e installation in CI workflow add image pull secret support (#1127) Update ci.yml Optimize CI workflow with enhanced cleanup and diagnostics Add optional lld installation and adjust build/test steps Optimize CI workflow for Rust builds # Conflicts: # .github/workflows/ci.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Related Issues
#1123
Summary of Changes
Checklist
make pre-commitImpact
Additional Notes
Thank you for your contribution! Please ensure your PR follows the community standards (CODE_OF_CONDUCT.md) and sign the CLA if this is your first contribution.