Fix initial dimensions of a fullscreen window on Windows#909
Conversation
Contributor
|
I think this may be in conflict with #895 |
Author
|
I think you're right. From a cursory glance at the changes of #895, it would also appear to fix the issue. However, the fullscreen example in that branch appears to be broken, so I cannot test this. |
Author
Merged
ghost
commented
Jun 13, 2019
Author
|
I've rebased this against |
Contributor
|
Yeah, git merging on CHANGELOG has always been somewhat shaky, and I'm not entirely sure why... I wonder if there's any way to change the merge algorithm git uses for that specific file. |
kosyak
pushed a commit
to kosyak/winit
that referenced
this pull request
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, creating a fullscreen window on Windows would result in the window spanning more than a single monitor since the DPI factor was not taken into account. A workaround was to manually specify the size for the window, but this is no longer necessary.
CHANGELOG.mdif knowledge of this change could be valuable to users