Feat/fullscreen getters#838
Feat/fullscreen getters#838Osspial merged 7 commits intorust-windowing:masterfrom acheronfail:feat/fullscreen-getters
Conversation
|
Related issue: #579 Thanks for doing this. |
Osspial
left a comment
There was a problem hiding this comment.
Hi, and thanks for the PR!
One design question - if we're going to be exposing the API, is there any technical reason we can't expose it as get_fullscreen() -> Option<MonitorId>? That exposes more information than just returning bool, and also makes the type signature symmetrical with set_fullscreen(Option<MonitorId>).
Other than that, the code changes look good on the Windows end.
Good idea, originally I made it a I've updated |
* feat: [macos] add get_fullscreen and get_simple_fullscreen * feat: [windows] add get_fullscreen * feat: [ios] add get_fullscreen * feat: [android] add get_fullscreen * feat: [emscripten] add get_fullscreen * feat: [linux] add get_fullscreen * feedback: `get_fullscreen() -> bool` -> `get_fullscreen() -> Option<Id>`
* feat: [macos] add get_fullscreen and get_simple_fullscreen * feat: [windows] add get_fullscreen * feat: [ios] add get_fullscreen * feat: [android] add get_fullscreen * feat: [emscripten] add get_fullscreen * feat: [linux] add get_fullscreen * feedback: `get_fullscreen() -> bool` -> `get_fullscreen() -> Option<Id>`
* feat: [macos] add get_fullscreen and get_simple_fullscreen * feat: [windows] add get_fullscreen * feat: [ios] add get_fullscreen * feat: [android] add get_fullscreen * feat: [emscripten] add get_fullscreen * feat: [linux] add get_fullscreen * feedback: `get_fullscreen() -> bool` -> `get_fullscreen() -> Option<Id>` AND: Fix macos compile error in fullscreen example (rust-windowing#885)
* feat: [macos] add get_fullscreen and get_simple_fullscreen * feat: [windows] add get_fullscreen * feat: [ios] add get_fullscreen * feat: [android] add get_fullscreen * feat: [emscripten] add get_fullscreen * feat: [linux] add get_fullscreen * feedback: `get_fullscreen() -> bool` -> `get_fullscreen() -> Option<Id>`
This change adds the
window.get_fullscreen()method - this is useful for many reasons and makes using this library much easier.It also adds a
get_simple_fullscreen()method to the macosWindowExtas well, so macos users can distinguish which type of fullscreen mode is currently active.I've tested this on the following platforms:
Closes #579