Skip to content

fix command key event left and right reverse on macOS#810

Merged
Osspial merged 3 commits intorust-windowing:masterfrom
TakWolf:master
Mar 25, 2019
Merged

fix command key event left and right reverse on macOS#810
Osspial merged 3 commits intorust-windowing:masterfrom
TakWolf:master

Conversation

@TakWolf
Copy link
Copy Markdown
Contributor

@TakWolf TakWolf commented Mar 9, 2019 •
edited
Loading

#808

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created an example program if it would help users understand this functionality

I only swapped the VirtualKeyCode mapping.

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Mar 20, 2019

Thanks! Sorry it took so long to get back on this - I kept putting it off and, well, here we are.

All that's missing is a changelog entry. Add that in, and I'll go ahead and merge this.

@TakWolf
Copy link
Copy Markdown
Contributor Author

TakWolf commented Mar 20, 2019 •
edited
Loading

I just made changes based on the results. I don't have a clear documentation reference but https://github.com/phracker/MacOSX-SDKs/blob/master/MacOSX10.6.sdk/System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/Headers/Events.h#L273

I'm not sure it is ok on all keyboard style.It is best to have another one to test this.

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Mar 20, 2019

Fair enough. @mtak- are you able to test this?

@Osspial Osspial mentioned this pull request Mar 22, 2019
Merged
@chrisduerr
Copy link
Copy Markdown
Contributor

chrisduerr commented Mar 25, 2019

@Osspial Just to potentially speed things up a bit, I've tested this on my macbook at work and I was able to confirm both that the current behavior is wrong (LWin and RWin swapped) and that this PR fixes that.

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Mar 25, 2019

@chrisduerr Thanks for the test! I'll merge this now.

@Osspial Osspial merged commit 57680d2 into rust-windowing:master Mar 25, 2019
elinorbgr pushed a commit to elinorbgr/winit that referenced this pull request Apr 7, 2019
@TakWolf @elinorbgr
fix command key event left and right reverse on macOS (rust-windowing…
c604c29 
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
elinorbgr pushed a commit to elinorbgr/winit that referenced this pull request Apr 7, 2019
@TakWolf @elinorbgr
fix command key event left and right reverse on macOS (rust-windowing…
9874181 
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
felixrabe pushed a commit to felixrabe/winit that referenced this pull request Jun 30, 2019
@TakWolf @felixrabe
fix command key event left and right reverse on macOS (rust-windowing…
97bb7f1 
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
kosyak pushed a commit to kosyak/winit that referenced this pull request Jul 10, 2019
@TakWolf
fix command key event left and right reverse on macOS (rust-windowing…
c99c9f4 
…#810)

* fix command key event left and right reverse on macOS

rust-windowing#808

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TakWolf @Osspial @chrisduerr