Add additional numpad key mappings#805
Merged
Osspial merged 2 commits intorust-windowing:masterfrom Apr 7, 2019
Merged
Conversation
Since some platforms have already used the existing `Add`, `Subtract` and `Divide` codes to map numpad keys, the X11 and Wayland platform has been updated to achieve parity between platforms. On macOS only the `Subtract` numpad key had to be added. Since the numpad key is different from the normal keys, an alternative option would be to add new `NumpadAdd`, `NumpadSubtract` and `NumpadDivide` actions, however I think in this case it should be fine to map them to the same virtual key code.
Contributor
|
Thanks for the PR! This looks good to me, but I'm going to cc @vberger and @francesca64 so they can take a look, as the maintainers of the changed platforms. |
Merged
goddessfreya
reviewed
Apr 7, 2019
Contributor
goddessfreya
left a comment
There was a problem hiding this comment.
Tested w/ wayland and x11, lgtm.
Contributor
|
Thanks! Merging |
elinorbgr
pushed a commit
to elinorbgr/winit
that referenced
this pull request
Apr 7, 2019
* Add additional numpad key mappings Since some platforms have already used the existing `Add`, `Subtract` and `Divide` codes to map numpad keys, the X11 and Wayland platform has been updated to achieve parity between platforms. On macOS only the `Subtract` numpad key had to be added. Since the numpad key is different from the normal keys, an alternative option would be to add new `NumpadAdd`, `NumpadSubtract` and `NumpadDivide` actions, however I think in this case it should be fine to map them to the same virtual key code. * Add Numpad PageUp/Down, Home and End on Wayland
elinorbgr
pushed a commit
to elinorbgr/winit
that referenced
this pull request
Apr 7, 2019
* Add additional numpad key mappings Since some platforms have already used the existing `Add`, `Subtract` and `Divide` codes to map numpad keys, the X11 and Wayland platform has been updated to achieve parity between platforms. On macOS only the `Subtract` numpad key had to be added. Since the numpad key is different from the normal keys, an alternative option would be to add new `NumpadAdd`, `NumpadSubtract` and `NumpadDivide` actions, however I think in this case it should be fine to map them to the same virtual key code. * Add Numpad PageUp/Down, Home and End on Wayland
elinorbgr
pushed a commit
to elinorbgr/winit
that referenced
this pull request
Apr 7, 2019
* Add additional numpad key mappings Since some platforms have already used the existing `Add`, `Subtract` and `Divide` codes to map numpad keys, the X11 and Wayland platform has been updated to achieve parity between platforms. On macOS only the `Subtract` numpad key had to be added. Since the numpad key is different from the normal keys, an alternative option would be to add new `NumpadAdd`, `NumpadSubtract` and `NumpadDivide` actions, however I think in this case it should be fine to map them to the same virtual key code. * Add Numpad PageUp/Down, Home and End on Wayland
felixrabe
added a commit
to felixrabe/winit
that referenced
this pull request
Jun 22, 2019
Osspial
pushed a commit
that referenced
this pull request
Jun 22, 2019
felixrabe
pushed a commit
to felixrabe/winit
that referenced
this pull request
Jun 30, 2019
* Add additional numpad key mappings Since some platforms have already used the existing `Add`, `Subtract` and `Divide` codes to map numpad keys, the X11 and Wayland platform has been updated to achieve parity between platforms. On macOS only the `Subtract` numpad key had to be added. Since the numpad key is different from the normal keys, an alternative option would be to add new `NumpadAdd`, `NumpadSubtract` and `NumpadDivide` actions, however I think in this case it should be fine to map them to the same virtual key code. * Add Numpad PageUp/Down, Home and End on Wayland
kosyak
pushed a commit
to kosyak/winit
that referenced
this pull request
Jul 10, 2019
* Add additional numpad key mappings Since some platforms have already used the existing `Add`, `Subtract` and `Divide` codes to map numpad keys, the X11 and Wayland platform has been updated to achieve parity between platforms. On macOS only the `Subtract` numpad key had to be added. Since the numpad key is different from the normal keys, an alternative option would be to add new `NumpadAdd`, `NumpadSubtract` and `NumpadDivide` actions, however I think in this case it should be fine to map them to the same virtual key code. * Add Numpad PageUp/Down, Home and End on Wayland
kosyak
pushed a commit
to kosyak/winit
that referenced
this pull request
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since some platforms have already used the existing
Add,Subtractand
Dividecodes to map numpad keys, the X11 and Wayland platform hasbeen updated to achieve parity between platforms. On macOS only the
Subtractnumpad key had to be added.Since the numpad key is different from the normal keys, an alternative
option would be to add new
NumpadAdd,NumpadSubtractandNumpadDivideactions, however I think in this case it should be fineto map them to the same virtual key code.