Skip to content

Use XRRGetScreenResourcesCurrent when avail.#801

Merged
Osspial merged 2 commits intorust-windowing:masterfrom
goddessfreya:stronger-faster
Mar 6, 2019
Merged

Use XRRGetScreenResourcesCurrent when avail.#801
Osspial merged 2 commits intorust-windowing:masterfrom
goddessfreya:stronger-faster

Conversation

@goddessfreya
Copy link
Copy Markdown
Contributor

@goddessfreya goddessfreya commented Feb 24, 2019

Signed-off-by: Hal Gentz zegentzy@protonmail.com

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created an example program if it would help users understand this functionality

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
@goddessfreya
Copy link
Copy Markdown
Contributor Author

This has been confirmed to speed up startup, see alacritty/alacritty#782 (comment)

r? @Osspial

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Feb 27, 2019

I don't see any issues with this, but I've got basically no experience with any non-Windows backend so this falls outside my area of knowledge. @francesca64 is the current maintainer for X11 so I'd be more comfortable merging this with her approval.

@goddessfreya
Copy link
Copy Markdown
Contributor Author

@francesca64 ?

@Osspial
Copy link
Copy Markdown
Contributor

Osspial commented Mar 5, 2019

Eh, it's been a week. Add a changelog entry and I'll go ahead and merge this.

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
@Osspial Osspial merged commit f928a4b into rust-windowing:master Mar 6, 2019
elinorbgr pushed a commit to elinorbgr/winit that referenced this pull request Apr 7, 2019
* Use `XRRGetScreenResourcesCurrent` when avail.

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>

* Changelog

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
elinorbgr pushed a commit to elinorbgr/winit that referenced this pull request Apr 7, 2019
* Use `XRRGetScreenResourcesCurrent` when avail.

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>

* Changelog

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
felixrabe pushed a commit to felixrabe/winit that referenced this pull request Jun 30, 2019
* Use `XRRGetScreenResourcesCurrent` when avail.

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>

* Changelog

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
kosyak pushed a commit to kosyak/winit that referenced this pull request Jul 10, 2019
* Use `XRRGetScreenResourcesCurrent` when avail.

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>

* Changelog

Signed-off-by: Hal Gentz <zegentzy@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants