Handle horizontal wheel input (Windows)#792
Merged
Osspial merged 2 commits intorust-windowing:masterfrom Feb 22, 2019
Merged
Conversation
Contributor
|
Hi, and thanks for the PR! You shouldn't need to add any documentation or examples, but since this is an improvement of functionality on Windows you should add a CHANGELOG entry. Other than that, this looks good! |
Contributor
Author
|
Ok, added a note about it! :) |
elinorbgr
pushed a commit
to elinorbgr/winit
that referenced
this pull request
Apr 7, 2019
* add handler for horizontal wheel input * add changlelog message re now handling horiz scroll on windows
elinorbgr
pushed a commit
to elinorbgr/winit
that referenced
this pull request
Apr 7, 2019
* add handler for horizontal wheel input * add changlelog message re now handling horiz scroll on windows
elinorbgr
pushed a commit
to elinorbgr/winit
that referenced
this pull request
Apr 7, 2019
* add handler for horizontal wheel input * add changlelog message re now handling horiz scroll on windows
felixrabe
pushed a commit
to felixrabe/winit
that referenced
this pull request
Jun 30, 2019
* add handler for horizontal wheel input * add changlelog message re now handling horiz scroll on windows
kosyak
pushed a commit
to kosyak/winit
that referenced
this pull request
Jul 10, 2019
* add handler for horizontal wheel input * add changlelog message re now handling horiz scroll on windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersCHANGELOG, documentation and example should not be needed for this one? Or let me know if you think otherwise and I will fix it :)