Prevent winit from overriding LSUIElement in package manifests#3920
Merged
madsmtm merged 4 commits intorust-windowing:masterfrom Sep 16, 2024
Merged
Conversation
madsmtm
requested changes
Sep 16, 2024
Member
madsmtm
left a comment
There was a problem hiding this comment.
Looks good with comments resolved, thanks!
Contributor
Author
|
@madsmtm addressed your comments, and thanks for the quick review! I've tested with a branch |
madsmtm
approved these changes
Sep 16, 2024
Contributor
Author
|
Awesome, thanks! |
This was referenced Oct 23, 2024
5 tasks
kchibisov
pushed a commit
that referenced
this pull request
Dec 16, 2024
kchibisov
pushed a commit
that referenced
this pull request
Dec 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #261
Essentially, MacOS users of applications that use
winitwere unable to setLSUIElementin theirpackage manifest to make the app behave as an agent app, even if the application itself wasn't
enforcing anything. This was because
winitwas using a default value ofActivationPolicy:Regularif none was provided, overriding anything in the package manifest.
So, make
with_activation_policyoverride package manifest only if explicitly specified.See ActivationPolicy docs, LSUIElement docs.
Tested with a branch off of v0.30.4, since v0.30.5 (clean) breaks the build of the application I'm using.
changelogmodule if knowledge of this change could be valuable to users