Implement ApplicationHandler for &mut A and Box<A>#3709
Merged
Conversation
notgull
requested changes
May 27, 2024
Contributor
notgull
left a comment
There was a problem hiding this comment.
I think we can also implement for Box<A>.
Member
Author
You're right, have done so now. |
notgull
approved these changes
May 28, 2024
&mut A&mut A and Box<A>
notgull
pushed a commit
that referenced
this pull request
Jun 1, 2024
2 tasks
kchibisov
pushed a commit
that referenced
this pull request
Jun 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not sure if there was a reason these implementations didn't exist before, but they're nice to have.
A future PR could change the signature of
run_appfrom taking&mut Ato just takingA(which, in turn, would allow us to makeDropwork better).changelogmodule if knowledge of this change could be valuable to users