Add ApplicationHandler and matching run APIs#3517
Merged
Conversation
3cf4bed to
71ca619
Compare
7 tasks
71ca619 to
94fa391
Compare
madsmtm
approved these changes
Mar 1, 2024
94fa391 to
4c830cb
Compare
notgull
approved these changes
Mar 2, 2024
daxpedda
requested changes
Mar 5, 2024
4c830cb to
33c133c
Compare
daxpedda
approved these changes
Mar 5, 2024
Add a simple `ApplicationHandler` trait since winit is moving towards trait based API. Add `run_app` group of APIs to accept `&mut impl ApplicationHandler` deprecating the old `run` APIs. Part-of: #3432
33c133c to
834f27b
Compare
madsmtm
added a commit
that referenced
this pull request
Mar 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Winit is moving towards trait based end user application structure, thus add a simple
ApplicationHandlertrait which follows theEvent<T>. To make use of this trait the newrun_appgroup of APIs were added with the oldrunAPIs being deprecated.Part-of: #3432. Replaces #3386 and #3073.
CHANGELOG.mdif knowledge of this change could be valuable to users