X11: cache custom cursors#3366
Merged
daxpedda merged 1 commit intorust-windowing:masterfrom Jan 17, 2024
Merged
Conversation
daxpedda
commented
Jan 5, 2024
| RootCustomCursor { | ||
| inner: PlatformCustomCursor::X11(_), | ||
| } => { | ||
| error!("passed a X11 cursor to Wayland backend"); |
Member
Author
There was a problem hiding this comment.
I could change those to unreachable!, because you can't recreate event loops on those platforms, right?
2c8142d to
2428a4a
Compare
2428a4a to
8be3d41
Compare
ee22f86 to
a14ddec
Compare
a14ddec to
8314e7f
Compare
jpedrick
pushed a commit
to jpedrick/winit
that referenced
this pull request
Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3306.
Wayland isn't really affected, just needed some slight refactoring to account for different backends.