Rename VideoMode to VideoModeHandle#3328
Merged
daxpedda merged 1 commit intorust-windowing:masterfrom Dec 26, 2023
Merged
Conversation
madsmtm
approved these changes
Dec 26, 2023
920e610 to
e26a5e0
Compare
4 tasks
madsmtm
added a commit
that referenced
this pull request
Mar 28, 2024
It was incorrectly marked as a breaking change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The point here is to reflect that
VideoModeis not a static blob of information, but a handle that dynamically accesses that information. This is in line with our otherMonitorHandletype.Addresses #3258.
Cc @madsmtm.