Web: Remove T from EventLoopTargetWindow#3081
Merged
daxpedda merged 1 commit intorust-windowing:masterfrom Sep 3, 2023
Merged
Conversation
Co-Authored-By: nerditation <12248559+nerditation@users.noreply.github.com>
9 tasks
Merged
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Oct 17, 2023
Co-authored-by: nerditation <12248559+nerditation@users.noreply.github.com>
kchibisov
pushed a commit
that referenced
this pull request
Oct 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @nerditation.
Currently our custom
Channeltype actually uses anstd::mpscchannel to send()to wake up the event loop. This is obviously nonsense because the actual user event already uses anstd::mpscand that way it can only handle a single user event at a time. I'm working currently on a rework that simply uses aAtomicUsizeto figure out exactly how many user events have been sent without any channel to begin with. Or maybe some other idea I can come up with 😅.Fixes the Web backend for #3053.