Fix pointer deltas on Firefox and send coalesced events together#2878
Merged
daxpedda merged 2 commits intorust-windowing:masterfrom Jun 13, 2023
Merged
Fix pointer deltas on Firefox and send coalesced events together#2878daxpedda merged 2 commits intorust-windowing:masterfrom
daxpedda merged 2 commits intorust-windowing:masterfrom
Conversation
df0d750 to
95b3410
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefox has broken movement values in coalesced events (Bugzilla), which I fixed in this PR by calculating our own deltas when detecting Firefox.
In this case I use the lack of
pointerrawupdatesupport and coalesced event support to detect Firefox and differentiate it from Safari. If Safari implements coalesced events this detection would break and we would have a (very small) increased overhead on Safari because the manual delta calculations we make would be unnecessary. When that happens we would have to do proper browser detection, which we should generally avoid, see MDN for more information. Browser support in general is tracked in #2875.Another change in this PR was how coalesced events are dispatched. Currently Winit restarts the event loop on every coalesced event separately. This is unnecessary because all coalesced events are available in the same callback. This required wasm-bindgen/wasm-bindgen#3477, which is why
js-syswas bumped here.I also made sure all
ModifiersChangedevents are sent together with any pointer events as well. This unfortunately caused a lot of code duplication, cleaning this up would require some re-architecturing, so hopefully I will get to that one day.Follow-up to #2847.
Contains split-off-changes from #2871.
Cc @cybersoulK.