Skip to content

On Web, implement DeviceEvents#2871

Merged
daxpedda merged 6 commits intorust-windowing:masterfrom
daxpedda:web-device-event
Jun 14, 2023
Merged

On Web, implement DeviceEvents#2871
daxpedda merged 6 commits intorust-windowing:masterfrom
daxpedda:web-device-event

Conversation

@daxpedda
Copy link
Copy Markdown
Member

@daxpedda daxpedda commented Jun 11, 2023

Tracking

  • MouseMotion
  • Motion
  • MouseWheel
  • Button
  • Key
  • Text (not implemented on any backend)

Changes

This PR intends to implements all DeviceEvents. Additionally DeviceEvents are only emitted according to the setting in EventLoopWindowTarget::listen_device_events().


Fixes #2036.

@daxpedda daxpedda added the DS - web Affects the Web backend (WebAssembly/WASM) label Jun 11, 2023
@daxpedda daxpedda changed the title Moved DeviceEvent::MouseMotion to browser window On Web, implement DeviceEvents Jun 11, 2023
@daxpedda
Copy link
Copy Markdown
Member Author

Just hit this bug on Mozilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1753724.
So basically I broke DeviceEvent::MouseMotion in Firefox in #2840 and didn't notice.

Will figure out a fix.

@daxpedda
Copy link
Copy Markdown
Member Author

I split off any pointer related fixes I originally implemented in this PR into #2878.

@daxpedda daxpedda force-pushed the web-device-event branch 3 times, most recently from fe19240 to cf940e8 Compare June 13, 2023 12:35
@daxpedda daxpedda marked this pull request as ready for review June 13, 2023 12:39
@daxpedda daxpedda force-pushed the web-device-event branch 2 times, most recently from 2aad007 to 414fad0 Compare June 13, 2023 22:09
@daxpedda daxpedda merged commit 6300cf9 into rust-windowing:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DS - web Affects the Web backend (WebAssembly/WASM)

Development

Successfully merging this pull request may close these issues.

Most Device events do not work on the web.

1 participant