Process pointer button events when a buttons is already pressed#2838
Merged
daxpedda merged 1 commit intorust-windowing:masterfrom Jun 2, 2023
Merged
Process pointer button events when a buttons is already pressed#2838daxpedda merged 1 commit intorust-windowing:masterfrom
daxpedda merged 1 commit intorust-windowing:masterfrom
Conversation
This was referenced Jun 2, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a pointer button is already pressed, new button presses/releases won't go through
pointerdown/pointerup, but throughpointermove, which is weird, but this PR now handles this correctly.Along the way I inlined some unnecessary variables and passed button identifiers into
MouseButton::Otherdirectly instead of subtracting 3 (I have no clue why this was originally made).Fixes #2455.
Cc #2475.
Replaces #2731.