Web: Only Use PointerEvent for Touch#2731
Closed
JAD3N wants to merge 4 commits intorust-windowing:masterfrom
JAD3N:fix-web-mouse-events
Closed
Web: Only Use PointerEvent for Touch#2731JAD3N wants to merge 4 commits intorust-windowing:masterfrom JAD3N:fix-web-mouse-events
JAD3N wants to merge 4 commits intorust-windowing:masterfrom
JAD3N:fix-web-mouse-events
Conversation
Author
|
Currently I've left all mouse event handlers in |
Member
|
This is definitely still a problem even after #2662, I will review this soon. You don't need to rebase it until I review the approach to this. |
This was referenced May 30, 2023
Member
|
I replaced this by #2838.
So we shouldn't need to handle both events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to usersThis builds on top of #2721 by making the mouse handler be the way to handle mouse events instead of pointer. Pointer events are still conditionally used (depending on browser support) for touch events.
By doing this it should resolve issue #2475 as pointer events don't trigger events for mouse buttons pressed while another mouse button is being held. More information can be found here but the main concern is in the first paragraph: