Remove assert for recovereable issue. Fixes #2597#2599
Remove assert for recovereable issue. Fixes #2597#2599madsmtm merged 2 commits intorust-windowing:masterfrom
Conversation
|
My best guess as to why this happens is that there's some sort of race-condition on the event registration - or maybe the scale-factor just changes enough such that the media query-state changes, while it is still within the specified bounds? Idk, anyhow, I would rather just remove the assertion altogether |
|
Should I remove it then? If so, then I can also remove the event parameter completely, as it won't be used anymore inside that function. What do you think? |
|
Yeah, go ahead and remove the assert and the parameter. |
|
Done! ✅ I haven't finally removed the |
|
That's fine, thanks! |
|
Great, thanks! How often do you release? I'd love to have it as a 0.27.x hotfix, if possible 🙏 Or should I open another PR cherry-picking the fix to the 0.27.x branch? |
|
See #2600 - I'd guess that 0.28 will land some time before February. |
Fixes #2597
CHANGELOG.mdif knowledge of this change could be valuable to users. Not relevant enough to go into CHANGELOG.md imo. ✅