Skip to content

Implement raw mouse motion for Windows#213

Merged
tomaka merged 1 commit intorust-windowing:masterfrom
LPGhatguy:windows-raw-mouse
Jul 5, 2017
Merged

Implement raw mouse motion for Windows#213
tomaka merged 1 commit intorust-windowing:masterfrom
LPGhatguy:windows-raw-mouse

Conversation

@LPGhatguy
Copy link
Copy Markdown
Contributor

This PR implement's @Ralith's original Motion API for Windows.

The event names will be be out of date if/when #192 lands, but it should be an easy change.

@tomaka
Copy link
Copy Markdown
Contributor

tomaka commented Jul 5, 2017

I'm wondering if RIDEV_INPUTSINK is a good idea. IIUC wayland doesn't allow this behavior, so we won't be able to reproduce this on all platforms.

@LPGhatguy
Copy link
Copy Markdown
Contributor Author

After reading the documentation more closely, adding that flag is most likely a mistake; the code is transcribed from a C++ example I found.

@LPGhatguy
Copy link
Copy Markdown
Contributor Author

@tomaka, I knocked that flag out and things appear to still work when the window is focused. Good catch!

@tomaka
Copy link
Copy Markdown
Contributor

tomaka commented Jul 5, 2017

Looks good now, thanks

@tomaka tomaka merged commit 601599e into rust-windowing:master Jul 5, 2017
@LPGhatguy LPGhatguy deleted the windows-raw-mouse branch July 5, 2017 07:38
Ralith added a commit to Ralith/winit that referenced this pull request Jul 18, 2017
An inconsistency was introduced by the independent merging of rust-windowing#211
with rust-windowing#213.
@Ralith Ralith mentioned this pull request Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants