Make size/position types generic over pixel type#1277
Merged
Osspial merged 12 commits intorust-windowing:dpi-overhaulfrom Nov 14, 2019
Merged
Make size/position types generic over pixel type#1277Osspial merged 12 commits intorust-windowing:dpi-overhaulfrom
Osspial merged 12 commits intorust-windowing:dpi-overhaulfrom
Conversation
4373a19 to
b6944b6
Compare
676a297 to
c90dc93
Compare
8a6429d to
da0b29e
Compare
7 tasks
7 tasks
Osspial
added a commit
that referenced
this pull request
Jan 4, 2020
* Begin implementing DPI generics * Fix multithreaded example * Format * Fix serde test * hopefully fix most of the errors * Fix dpi module errors * More error fixings * Format * fix macos errors * Another error pass * Replace bad type signatures * more fixins
Osspial
added a commit
that referenced
this pull request
Jan 4, 2020
* Begin implementing DPI generics * Fix multithreaded example * Format * Fix serde test * hopefully fix most of the errors * Fix dpi module errors * More error fixings * Format * fix macos errors * Another error pass * Replace bad type signatures * more fixins
Osspial
added a commit
that referenced
this pull request
Jan 4, 2020
* Begin implementing DPI generics * Fix multithreaded example * Format * Fix serde test * hopefully fix most of the errors * Fix dpi module errors * More error fixings * Format * fix macos errors * Another error pass * Replace bad type signatures * more fixins
Osspial
added a commit
that referenced
this pull request
Jan 5, 2020
* Begin implementing DPI generics * Fix multithreaded example * Format * Fix serde test * hopefully fix most of the errors * Fix dpi module errors * More error fixings * Format * fix macos errors * Another error pass * Replace bad type signatures * more fixins
Osspial
added a commit
that referenced
this pull request
Jan 5, 2020
* Begin implementing DPI generics * Fix multithreaded example * Format * Fix serde test * hopefully fix most of the errors * Fix dpi module errors * More error fixings * Format * fix macos errors * Another error pass * Replace bad type signatures * more fixins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchcargo docbuilds successfullyCHANGELOG.mdif knowledge of this change could be valuable to usersImplements the changes suggested in #1135 (comment). I haven't gotten around to updating the type signatures on non-Windows platforms but I'll go through the CI logs after they fail and update them where necessary.