X11: Fix events not being reported promptly#1048
Merged
Osspial merged 2 commits intorust-windowing:masterfrom Jul 17, 2019
Merged
X11: Fix events not being reported promptly#1048Osspial merged 2 commits intorust-windowing:masterfrom
Osspial merged 2 commits intorust-windowing:masterfrom
Conversation
Contributor
Author
|
I believe this should fix both rust-windowing/glutin#1054 and rust-windowing/glutin#1193 |
Contributor
|
cc @chrisduerr |
|
Thanks for all your work on this! I just tested it and can confirm that it fixed the issues I was having in rust-windowing/glutin#1193 |
goddessfreya
approved these changes
Jul 17, 2019
Contributor
goddessfreya
left a comment
There was a problem hiding this comment.
lgtm, altho I'd like to wait to make sure this doesn't cause anything silly in alacritty.
Contributor
|
Can we get a changelog entry before merging this? |
Contributor
Author
|
Added an entry to the changelog and rebased to resolve the conflict. |
felixrabe
pushed a commit
to felixrabe/winit
that referenced
this pull request
Jul 24, 2019
* X11: Fix events not being reported promptly * Add an entry to the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmthas been run on this branchCHANGELOG.mdif knowledge of this change could be valuable to users