Skip to content

Fix EGL for wayland.#690

Merged
tomaka merged 1 commit intorust-windowing:masterfrom
elinorbgr:master
Jan 3, 2016
Merged

Fix EGL for wayland.#690
tomaka merged 1 commit intorust-windowing:masterfrom
elinorbgr:master

Conversation

@elinorbgr
Copy link
Contributor

These are the changes I managed to get EGL context initialization to work on wayland on my computer.

I don't really know what all that implies, it was mostly try and retry.

Your thoughts @tomaka ?

@tomaka
Copy link
Contributor

tomaka commented Dec 31, 2015

Do you get an error with EGL_SURFACE_TYPE?

@elinorbgr
Copy link
Contributor Author

If I don't comment out the SURFACE_TYPE block, eglChooseConfig triggers a EGL_BAD_ATTRIBUTE.

No idea what's causing this, maybe a bug in my version of Mesa? Could be nice if someone else could test as well.

@tomaka
Copy link
Contributor

tomaka commented Dec 31, 2015

Well, I noticed an error in that SURFACE_TYPE, PBUFFER_BIT and WINDOW_BIT are supported even by EGL 1.0. So that if should be removed.

@tomaka
Copy link
Contributor

tomaka commented Dec 31, 2015

@vberger What happens if you leave only WINDOW_BIT?

@elinorbgr
Copy link
Contributor Author

@tomaka cannot test it right now, will do it later in the afternoon.

However, if I remember correctly what I read in the EGL spec, having only WINDOW_BIT is the default value for this attribute.

@tomaka
Copy link
Contributor

tomaka commented Dec 31, 2015

having only WINDOW_BIT is the default value for this attribute.

That's why I'm asking what happens.

@elinorbgr
Copy link
Contributor Author

By removing PBUFFER_BIT it works as well.

@tomaka
Copy link
Contributor

tomaka commented Dec 31, 2015

Please add a comment in the code explaining the situation, then I'll merge.

@elinorbgr elinorbgr changed the title [WIP] Fix EGL for wayland. Fix EGL for wayland. Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants