Conversation
…ust our usage as necessary.
Collaborator
|
This is fantastic. Makes sense to test on some downstream projects first |
Member
|
LGTM. I agree on testing this before cutting a new release. |
Member
Author
|
Have been running the main branch over the weekend and things look fine so far. So from my point of view we could release 0.21.0. How about you? |
Member
|
Excellent, I will release 0.21.0 ASAP |
Member
Released! |
jasonmc
added a commit
to jasonmc/fixepub
that referenced
this pull request
Jan 25, 2025
rust-scraper/scraper#214 changed the nature of the tree sink.
jasonmc
added a commit
to jasonmc/fixepub
that referenced
this pull request
Jan 25, 2025
rust-scraper/scraper#214 changed the nature of the tree sink.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This appears to work though the changes are a bit more intrusive this time. My suggestion would be to review this, merge the result and then test the main branch in our downstream projects before releasing it on crates.io to gain the necessary confidence in the API adaptations.