Fix lifetime in ElementRef::attr return value#154
Merged
cfvescovo merged 1 commit intorust-scraper:masterfrom Oct 27, 2023
Merged
Fix lifetime in ElementRef::attr return value#154cfvescovo merged 1 commit intorust-scraper:masterfrom
cfvescovo merged 1 commit intorust-scraper:masterfrom
Conversation
This makes it usable in more contexts.
Member
|
Good catch |
Member
|
I am running into this as well now that I want to use this new helper method. A 0.18.1 patch release to fix this would be great. (I think this should be backwards compatible as the lifetime is strictly longer.) |
Member
|
I am releasing the patch |
Member
|
Thank you for investing your time to make the fix available! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to used the new accessor (from #140) on release and fixed a gotcha.
This allows returning references to the document when the traversal is done in an inner function.