Make some minor improvements to the code base#140
Merged
cfvescovo merged 3 commits intorust-scraper:masterfrom Aug 12, 2023
adamreichold:boy-scouting
Merged
Make some minor improvements to the code base#140cfvescovo merged 3 commits intorust-scraper:masterfrom adamreichold:boy-scouting
cfvescovo merged 3 commits intorust-scraper:masterfrom
adamreichold:boy-scouting
Conversation
Our code base is littered with calls to `element.value().attr("attribute")` and
this little method would make this much more readable by shorting it to
`element.attr("attribute")`.
Generally, I would also consider `impl Deref<Target=Element>` instead of `impl
Deref<Target=NodeRef>` but that would be incompatible and more intrusive.
Member
|
LGTM |
cfvescovo
approved these changes
Aug 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ElementRef::attrforwarding methodOur code base is littered with calls to
element.value().attr("attribute")and this little method would make this much more readable by shorting it toelement.attr("attribute").Generally, I would also consider
impl Deref<Target=Element>instead ofimpl Deref<Target=NodeRef>but that would be incompatible and more intrusive.