Disable std feature by default in rand_core and rand_jitter#703
Disable std feature by default in rand_core and rand_jitter#703dhardy merged 2 commits intorust-random:masterfrom
Conversation
|
Does the test fail because of the dead links? |
|
I don't know; I'm looking into the deadlinks now. |
|
AppVeyor fails since Of course, we also need a compatibility shim for |
|
I can't find the deadlinks when following the Travis CI procedure. If I just do I think deploying this will break builds on SGX since that uses RDRAND which depends on |
--package causes problems where multiple versions exist (an issue since rdrand depends on rand_core:0.3). Also, we definitely don't need both.
|
The Travis deadlinks check is still going on about
many times over. Perhaps there's a missing crate name between the double //, but I'm not sure why it's linking to the index page (I checked all mentions of 'index'). |
|
I was planning on publishing this today, but without further feedback or a solution to that CI error I'd rather hold off a little longer. Any ideas? |
|
Well, both these CI errors are happening on other PRs, so I will go ahead and merge. |
Implements #702
Resolves #645
Publishing under a new version is the correct way of doing things.
I took the liberty of applying the same logic to
rand_jitter, which does have more requirement to use itsstdfeature but is also a "low level" crate (and not yet published, hence not a breaking change).I also forced
rand_jitterto forward thestdfeature torand_core, not because it needs it but because it re-exportsrand_coreand is thus more consistent for users. By the same logic,rand_osnow requiresstdonrand_core.