-
-
Notifications
You must be signed in to change notification settings - Fork 489
Closed
Description
If we do this,
- direct users of
rand_coremight have issues (if they don't request thestdfeature and try to use missing functionality) - indirect users of
rand_core(i.e. users ofrandetc.) shouldn't notice any differences, so long as the direct dependencies use the feature correctly - this should help avoid problems like in Having
rand0.5 andrand0.6 with default features turned off in the crate graph results in a compliation error #645, where the build happens to requirestdinrand_core(likely accidentally) but not inrand
There isn't a lot of functionality in rand_core which is enabled by the std feature, but there is a little:
rand_core::Error::take_erroris definedrand_core::Errorimplementsstd::error::Errorstd::io::ErrorimplementsFrom<rand_core::Error>RngCoreimplementsstd::io::Read
Of course, this is potentially a breaking change, so we should bump the version number to 0.4.0 and have a shim 0.3 → 0.4 which still enables std by default — except, since the change is unlikely to cause much breakage and we are already breaking some builds, I wonder if it is worth it?
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels