Merged
Conversation
It solves a problem with modern clang generating invalid Idents for anonymous unions.
Contributor
Author
|
Ping, the appveyor error seems unrelated to this patch. |
|
I'm building tremor-rs on AlpineLinux and also hit this error, as Alpine's edge repo already started to phase out clang15. Would love to have this merged, and also a new release cut with the change. |
|
@iwillspeak would it be possible to merge this ? thanks |
jayvdb
approved these changes
Apr 7, 2023
iwillspeak
approved these changes
Jun 11, 2023
|
@iwillspeak @jayvdb Since the latest, published version of the # Cargo.toml
[dependencies]
onig = { git = "https://github.com/rust-onig/rust-onig", revision = "fa90c0e97e90a056af89f183b23cd417b59ee6a2" }
[patch.crates-io]
onig_sys = { git = "https://github.com/rust-onig/rust-onig", revision = "fa90c0e97e90a056af89f183b23cd417b59ee6a2" } |
greymd
added a commit
to greymd/teip
that referenced
this pull request
Jan 1, 2024
To avoid the build failure, apply the workaround disscussed here rust-onig/rust-onig#174 If the new version of onig crate is released, revert this changes.
|
Please publish a release with this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It solves a problem with modern clang generating invalid Idents for anonymous unions.
Fixes #173