Closed
Conversation
Collaborator
|
Thanks for the contribution. I think I would rather fix the |
Merged
Collaborator
|
I'm going to close this PR in favour of #162 . That adds support for proper round tripping of the bits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deals with a bug I encountered when trying to set
SyntaxOperator::SYNTAX_OPERATOR_ESC_X_BRACE_HEX8with
pythonsyntax with theset_operatorsfunction.What would happen is that
set_operatorswould override theop2fields.So I added functions to deal explicitly withe
opandop2