Use i64, and allow trivial_numeric_casts#7
Merged
Conversation
The traits are implemented from 64-bit values, and we don't want to lose any bits when comparing on platforms with smaller `isize`.
Simple enum expressions may have no explicit type, like `A = 1`, so then the derived `1 as i64` is inferred like `1i64 as i64`, a trivial numeric cast. But it's quite possible that other expressions could have explicit types, so we can't just assign it directly either. The simple solution is to just allow the `trivial_numeric_casts` in derived code.
Contributor
|
great job! |
Member
Author
|
Thanks for checking it! bors r+ |
bors Bot
added a commit
that referenced
this pull request
Jan 23, 2018
7: Use i64, and allow trivial_numeric_casts r=cuviper a=cuviper The traits are implemented from 64-bit values, and we don't want to lose any bits when comparing on platforms with smaller `isize`. Simple enum expressions may have no explicit type, like `A = 1`, so then the derived `1 as i64` is inferred like `1i64 as i64`, a trivial numeric cast. But it's quite possible that other expressions could have explicit types, so we can't just assign it directly either. The simple solution is to just allow the `trivial_numeric_casts` in derived code. Fixes #6.
Contributor
|
Wait, I didn't check it yet :) Going to do it now. Yep, it does! 🎉 |
Contributor
Build succeeded |
Member
Author
|
Oops. :) I'll wait for you before I publish anything... |
Contributor
|
@cuviper see edit :) I actually was going to sleep, but your response has waken me up 😄 P.S. Shouldn't we update version? |
Member
Author
|
(quietly) num-traits 0.1.43 is published -- good night! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The traits are implemented from 64-bit values, and we don't want to lose
any bits when comparing on platforms with smaller
isize.Simple enum expressions may have no explicit type, like
A = 1, so thenthe derived
1 as i64is inferred like1i64 as i64, a trivial numericcast. But it's quite possible that other expressions could have explicit
types, so we can't just assign it directly either. The simple solution is
to just allow the
trivial_numeric_castsin derived code.Fixes #6.