bigint: Create the parsing error better for nested +#269
Merged
homu merged 2 commits intorust-num:masterfrom Mar 8, 2017
Merged
bigint: Create the parsing error better for nested +#269homu merged 2 commits intorust-num:masterfrom
+#269homu merged 2 commits intorust-num:masterfrom
Conversation
If a `+` is encountered in the middle of parsing a BigUint, this should generate an `ParseIntError::InvalidDigit`. Since we can't create that directly, we get it by trying to parse a `u64` from this point, but of course `+` is a perfectly valid prefix to a `u64`. Now we include the previous character in the string passed to `u64`, so it has proper parsing context to understand what's in error. Fixes rust-num#268.
Member
Author
|
@homu r+ |
Contributor
|
📌 Commit 0b6cae0 has been approved by |
Contributor
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Mar 8, 2017
bigint: Create the parsing error better for nested `+` If a `+` is encountered in the middle of parsing a BigUint, this should generate an `ParseIntError::InvalidDigit`. Since we can't create that directly, we get it by trying to parse a `u64` from this point, but of course `+` is a perfectly valid prefix to a `u64`. Now we include the previous character in the string passed to `u64`, so it has proper parsing context to understand what's in error. Fixes #268.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
+is encountered in the middle of parsing a BigUint, this shouldgenerate an
ParseIntError::InvalidDigit. Since we can't create thatdirectly, we get it by trying to parse a
u64from this point, but ofcourse
+is a perfectly valid prefix to au64.Now we include the previous character in the string passed to
u64, so ithas proper parsing context to understand what's in error.
Fixes #268.