This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Cache processes to execute for the workspace inter-target dep graph#453
Merged
nrc merged 2 commits intorust-lang:masterfrom Aug 22, 2017
Merged
Cache processes to execute for the workspace inter-target dep graph#453nrc merged 2 commits intorust-lang:masterfrom
nrc merged 2 commits intorust-lang:masterfrom
Conversation
Nashenas88
reviewed
Aug 22, 2017
src/build/cargo.rs
Outdated
| let mut cx = self.compilation_cx.lock().unwrap(); | ||
|
|
||
| let mut store_cmd = process_builder::process(&rustc_exe); | ||
| store_cmd.args(&args.iter().map(|s| OsString::from(s)).collect::<Vec<OsString>>()); |
Contributor
There was a problem hiding this comment.
You can just use .map(OsString::from) here since it's a single parameter function. I believe you should also be able to independently have collect::<Vec<_>> too since the map always generates OsStrings.
Contributor
Author
There was a problem hiding this comment.
You're right, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #449. This limits the inter-target dep graph to the targets in the workspace and caches appropriate
rustccommands (after being modified by the RLS) for appropriate units to build.This still needs implementing fetching dirty target dep graphs, sorting the nodes topologically and implementing a simple job queue. If this is too little to merge right now, I can push more changes to this branch so more work can be merged at once if needed.