This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Create and cache inter-target dep graph during Cargo build routine#449
Merged
nrc merged 1 commit intorust-lang:masterfrom Aug 21, 2017
Merged
Create and cache inter-target dep graph during Cargo build routine#449nrc merged 1 commit intorust-lang:masterfrom
nrc merged 1 commit intorust-lang:masterfrom
Conversation
Xanewok
commented
Aug 20, 2017
| // TODO: Support more crate target types | ||
| &[], false, &[], false, &[], false), | ||
| &[], false, &[], false, &[], false, | ||
| false), |
Contributor
Author
There was a problem hiding this comment.
This is a new all_targets option, added in the newer versions of Cargo (using Cargo PR branch meant also using newest Cargo master).
Member
|
#448 and the Cargo PR are both merged now, so you should be able to rebase this PR and change the Cargo.toml back to Cargo master. |
Member
|
Looks good! |
Needs updated cargo for the additional information in `Executor` callbacks.
Contributor
Author
Done! |
This was referenced Aug 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #448. Since it seems this PR also pulls this automatically, I'm not sure if it's possible to merge one and the other with proper history, so I can update this PR if #448 will be merged to include only the last commit.
Also depends on rust-lang/cargo#4416, so until that's merged, I'm using the https://github.com/Xanewok/cargo/tree/more-executor-params branch with the changes.
By exposing
&UnitinExecutor::init()we can create a target dependency graph with ease, without having to explicitly copy over any Cargo code. This only currently fetches the dep graph after eachcargobuild routine, an example output (done for therlsitself) can be found here: https://pastebin.com/iSz4pcuK.Next stage should be to cache exact
ProcessBuilders for executed units of work and create our own JobQueue (or maybe it'll be possible to reuse more Cargo API, since we'll have pseudo-Units at our disposal).