This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Initialize RlsExecutor during new() instead of during init()#448
Merged
nrc merged 1 commit intorust-lang:masterfrom Aug 20, 2017
Merged
Initialize RlsExecutor during new() instead of during init()#448nrc merged 1 commit intorust-lang:masterfrom
new() instead of during init()#448nrc merged 1 commit intorust-lang:masterfrom
Conversation
`fn init()` is called each time `rustc` command is prepared, so we ended up calling it as many times as there were `rustc` invocations for the package/workspace. To initialize the packages we only need `Workspace`, which we do create already when creating `RlsExecutor` - so just pass it and use it when calling `RlsExecutor::new()`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
init()is called each timerustccommand is prepared, so we ended up calling it as many times as there wererustcinvocations for the package/workspace.To initialize the packages we only need
Workspace, which we do create already when creatingRlsExecutor- so just pass it and use it when callingRlsExecutor::new().@nrc as you said when I first introduced the workspace_mode, this should probably be in a separate enum to better split
cur_package_idandmember_packageslogic/storage, but I think it'd be good to do once the workspace_mode design stabilises a bit.Related: rust-lang/cargo#4416