Add exclude-titles option to no-mentions #2137
Conversation
ebe030e to
66da374
Compare
|
A more principal fix would be to ignore subtree syncs, probably by adding a config on Would you be willing to implement this instead? I can provide guidance. If not, that's okay, we can merge this PR in the meantime. |
|
Yes I'd be willing to implement such a change, triagebot is a project I like working on. Although I'm not sure how many titles that aren't subtree syncs (and thus, contain merge commits mentioning rustbot) would benefit from disabling the no-mentions check. |
|
I proposed title based exclusion because that's what we currently do for the I don't think only excluding As for other PRs that aren't subtree sync, we may still want to exclude |
Allow ignoring some pull requests such as subtree updates, as they don't benefit from a no-mentions warning.
66da374 to
042a6be
Compare
exclude-titles option to no-mentions
|
Done! I've reoriented the pull request and added support for a new |
Urgau
left a comment
There was a problem hiding this comment.
Looks good. Two nits and we should be good to go.
6e2f821 to
ce67228
Compare
ce67228 to
cb79f88
Compare
Urgau
left a comment
There was a problem hiding this comment.
Thanks for working on this. Let's ship it.
triagebot: Don't warn no-mentions on subtree updates Complement to rust-lang/triagebot#2137 r? `@Urgau`
triagebot: Don't warn no-mentions on subtree updates Complement to rust-lang/triagebot#2137 r? ``@Urgau``
triagebot: Don't warn no-mentions on subtree updates Complement to rust-lang/triagebot#2137 r? `@Urgau`
triagebot: Don't warn no-mentions on subtree updates Complement to rust-lang/triagebot#2137 r? ``@Urgau``
|
@blyxyas Forgot to ask, would you be up sending a PR updating the documentation of |
Rollup merge of #145542 - blyxyas:no-mentions-subtree, r=Urgau triagebot: Don't warn no-mentions on subtree updates Complement to rust-lang/triagebot#2137 r? ``@Urgau``
|
Yeah, of course! I'll open it ASAP |
triagebot: Don't warn no-mentions on subtree updates Complement to rust-lang/triagebot#2137 r? ``@Urgau``
Previously, users were getting warnings for including merge commits to PRs that mentioned only @rustbot (Example). Now it has to have at least one human mentioned in order to trigger a comment.