Add option to disable checking issue links in commits#1966
Merged
Conversation
Kobzol
approved these changes
May 5, 2025
Kobzol
left a comment
Member
There was a problem hiding this comment.
I would find it more intuitive if the option disabled commit checking, rather than allowed issues in commits (e.g. check-commits = false), but it's not super important. Feel free to merge as is.
42723d6 to
a0946d7
Compare
Member
Author
|
Switched to |
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
May 12, 2025
Disable warnings when crosslinking issues, since we do want contributors to do this. Cc: rust-lang/triagebot#1966
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
May 12, 2025
Disable warnings when crosslinking issues, since we do want contributors to do this. Cc: rust-lang/triagebot#1966
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
May 12, 2025
Disable warnings when crosslinking issues, since we do want contributors to do this. Cc: rust-lang/triagebot#1966
Contributor
|
It looks like this added a new config option. Can you make sure this gets added to the documentation? |
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
Disable warnings when crosslinking issues, since we do want contributors to do this. Cc: rust-lang/triagebot#1966 (backport <rust-lang#4444>) (cherry picked from commit 6a8609c)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Jun 1, 2025
Disable warnings when crosslinking issues, since we do want contributors to do this. Cc: rust-lang/triagebot#1966 (backport <rust-lang#4444>) (cherry picked from commit 6a8609c)
DorianNiemiecSVRJS
pushed a commit
to DorianNiemiecSVRJS/rust-libc
that referenced
this pull request
Jun 21, 2025
Disable warnings when crosslinking issues, since we do want contributors to do this. Cc: rust-lang/triagebot#1966 (backport <rust-lang#4444>) (cherry picked from commit 6a8609c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an option (
allowed-in-commitsMore context in #1965 (comment), but summary: repository that aren't subtrees in r-l/r don't necessarily need to prevent issue links in commits.
Fixes #1965