Ignore inline HTML and HTML blocks#1869
Merged
ehuss merged 4 commits intorust-lang:masterfrom Jan 6, 2025
Merged
Conversation
ehuss
added a commit
to rust-lang/rust-forge
that referenced
this pull request
Jan 6, 2025
This is the companion to rust-lang/triagebot#1869
Urgau
added a commit
to Urgau/rust
that referenced
this pull request
Jan 7, 2025
as triagebot/rustbot now ignores HTML blocks. cf. rust-lang/triagebot#1869
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 7, 2025
Remove workaround from pull request template This PR removes the workaround (`\`) from our pull request template as triagebot/rustbot now ignores HTML blocks. cf. rust-lang/triagebot#1869 cc `@jieyouxu` r? `@ehuss`
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 7, 2025
Rollup merge of rust-lang#135189 - Urgau:triagebot-html-ignored, r=lqd Remove workaround from pull request template This PR removes the workaround (`\`) from our pull request template as triagebot/rustbot now ignores HTML blocks. cf. rust-lang/triagebot#1869 cc `@jieyouxu` r? `@ehuss`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds inline HTML (
<a>) and HTML blocks to the ignore logic when parsing commands.This is particularly useful for rust-lang/rust pull request template which currently hacks around triagebot finding
r?in the HTML comment.This PR also updates
pulldown-cmarkto0.12.Related to #1832
r? @ehuss