wasm: Mark simd intrinsics as stable#1179
Merged
Amanieu merged 2 commits intorust-lang:masterfrom Jun 10, 2021
Merged
Conversation
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
This is a follow-up from rust-lang/rust#74372 which has finished FCP for the stabilization of wasm intrinsics. This marks them all stable, as-is and additionally marks the functions which create integer vectors as `const`-stable as well. The only remaining unstable bits are that `f32x4` and `f64x2` are `const`-unstable. Mostly just because I couldn't figure out how to make them `const`-stable.
1bce92d to
2cb8ba7
Compare
Member
|
What is the problem with const |
Member
Author
|
Attempting to Attempting to const-stabilize the Basically since I was trying to follow the same reasons as this unstable annotation but it appears I got the issues mixed up. The issue that points to is rust-lang/rust#72447. I'll update the links here to point to that issue. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jun 11, 2021
This commit performs two changes to stabilize Rust support for WebAssembly simd intrinsics: * The stdarch submodule is updated to pull in rust-lang/stdarch#1179. * The `wasm_target_feature` feature gate requirement for the `simd128` feature has been removed, stabilizing the name `simd128`. This should conclude the FCP started on rust-lang#74372 and... Closes rust-lang#74372
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2021
std: Stabilize wasm simd intrinsics This commit performs two changes to stabilize Rust support for WebAssembly simd intrinsics: * The stdarch submodule is updated to pull in rust-lang/stdarch#1179. * The `wasm_target_feature` feature gate requirement for the `simd128` feature has been removed, stabilizing the name `simd128`. This should conclude the FCP started on rust-lang#74372 and... Closes rust-lang#74372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up from rust-lang/rust#74372 which has finished FCP for
the stabilization of wasm intrinsics. This marks them all stable, as-is
and additionally marks the functions which create integer vectors as
const-stable as well. The only remaining unstable bits are thatf32x4andf64x2areconst-unstable. Mostly just because I couldn'tfigure out how to make them
const-stable.