This repository was archived by the owner on Nov 24, 2023. It is now read-only.
Revert revert multiple suggestions fix#195
Merged
Manishearth merged 3 commits intorust-lang:masterfrom Jun 1, 2021
Merged
Conversation
Manishearth
approved these changes
Jun 1, 2021
Collaborator
|
Can someone publish a new version? Maybe @killercup? |
Contributor
|
Sorry, I'm on vacation and didn't see the ping. I'm publishing all the latest changes as 0.6.0. Update: |
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
Jun 10, 2021
Update rustfix. This updates rustfix to 0.6.0. There are a few changes since 0.5.0, the following are noticeable changes: * rust-lang/rustfix#185 — Fix some panics in edge cases. * rust-lang/rustfix#195 — Revert revert multiple suggestions fix The important one is rust-lang/rustfix#195 which is necessary to handle some 2021 edition migration support. I have added a test to check that it works correctly.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 21, 2021
Rustfix update This updates to rustfix 0.6.0. One of the key changes here is rust-lang/rustfix#195 which changes rustfix to apply multi-part suggestions. One of the tests needs to updated because there are some overlapping suggestions which rustfix cannot handle. The solution is to only apply the machine-applicable suggestions to avoid the overlapping issue. This also includes a minor change to compiletest to provide better error messages with rustfix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This re-applies #155, as proposed in rust-lang/rust#53934 (comment).