This repository was archived by the owner on Aug 25, 2025. It is now read-only.
Write out manifest.in entries deterministically#120
Merged
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom Feb 4, 2023
Merged
Write out manifest.in entries deterministically#120Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
Mark-Simulacrum merged 1 commit intorust-lang:masterfrom
Conversation
Currently, the order of the entries in `manifest.in` depends on the iteration order of `copy_with_callback`, which in turn depends on `WalkDir`, which explicitly says iteration order is unspecified. It's possible to call `WalkDir::sort_by` to give an iteration order for each directory's entries, but it felt better to accumulate the lines and then sort them to a) make it more evident that this is happening, and b) enable the copying to be parallelized in the future.
|
Failed to set assignee to
|
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon. |
Mark-Simulacrum
approved these changes
Feb 4, 2023
Member
Mark-Simulacrum
left a comment
There was a problem hiding this comment.
We'll want a PR against rust-lang/rust bumping the submodule there to get these changes into releases.
Contributor
Author
|
Done! rust-lang/rust#107656 |
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 4, 2023
Makes generation of `manifest.in` deterministic: rust-lang/rust-installer#120
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 8, 2023
…-Simulacrum Bump rust-installer Makes generation of `manifest.in` deterministic: rust-lang/rust-installer#120
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 8, 2023
…-Simulacrum Bump rust-installer Makes generation of `manifest.in` deterministic: rust-lang/rust-installer#120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the order of the entries in
manifest.independs on the iteration order ofcopy_with_callback, which in turn depends onWalkDir, which explicitly says iteration order is unspecified. It's possible to callWalkDir::sort_byto give an iteration order for each directory's entries, but it felt better to accumulate the lines and then sort them to a) make it more evident that this is happening, and b) enable the copying to be parallelized in the future.