Fix false positives in duration_suboptimal_units for small literals#16565
Fix false positives in duration_suboptimal_units for small literals#16565Hectonight wants to merge 3 commits into
Conversation
|
r? @llogiq rustbot has assigned @llogiq. Use Why was this reviewer chosen?The reviewer was selected based on:
|
|
☔ The latest upstream changes (possibly 739f462) made this pull request unmergeable. Please resolve the merge conflicts. |
There was a problem hiding this comment.
Apparently there was another PR which addressed the same issue: #16596; I personally like its descriptive comments, because they explain not only the what, but also the why -- could you please port them to your PR? Though maybe it would make sense to put them into the lint description, so that they are more easily accessible to the end users, and in the comment above the check itself, just refer the reader to the description.
|
This PR looks extremely close but forgotten. How can I help get this across the finish line? |
|
Hello @tanndlin, thank you for your interest:) I think your best bet would be to open a copy of this PR, fix the merge conflicts, and add the comments I've proposed in the comment above; then we can review it:) |
*[View all comments](https://triagebot.infra.rust-lang.org/gh-comments/rust-lang/rust-clippy/pull/16922)* fixes rust-lang#16532 changelog: [`duration_suboptimal_units`]: fix false positive for small integer literals whose promoted value would be at most 10. Combined rust-lang#16565 and rust-lang#16596
fixes #16532
changelog: Fix [
duration_suboptimal_units] false positive for small integer literals (at most 10).