Enhance needless_collect to cover vec push-alike
#16305
Merged
+474
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
needless_collect to cover vec pushneedless_collect to cover vec push-alike
llogiq
reviewed
Jan 1, 2026
Member
Author
|
Emm.., I just realize that |
llogiq
reviewed
Jan 2, 2026
Comment on lines
+222
to
+230
| LL ~ | ||
| LL | | ||
| LL ~ | ||
| LL ~ | ||
| LL ~ | ||
| LL ~ | ||
| LL ~ | ||
| LL ~ | ||
| LL ~ |
Contributor
There was a problem hiding this comment.
What's up with this? Empty spans perhaps?
Member
Author
There was a problem hiding this comment.
The pushs are removed in the suggestions, leaving these empty lines
Contributor
There was a problem hiding this comment.
In that case, unless there is something non-whitespace between the spans, we may want to combine them into one span.
But again, that doesn't need to be in this PR.
Contributor
|
Ok, we can merge this and create follow-up PRs for further changes. Thank you! |
ada4a
pushed a commit
to ada4a/rust-clippy
that referenced
this pull request
Jan 12, 2026
Closes rust-lang#14946 Implemented as an enhancement to `needless_collect` changelog: [`needless_collect`] enhance to cover vec `push`-alike cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14946
Implemented as an enhancement to
needless_collectchangelog: [
needless_collect] enhance to cover vecpush-alike cases